gateway: add model property & implement SwitchOneChannel #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rytilahti all checks now pass, can this be merged? |
rytilahti
reviewed
Jun 11, 2020
rytilahti
approved these changes
Jun 11, 2020
rytilahti
changed the title
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* add model property & implement SwitchOneChannel * fix black formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the SwitchOneChannel device with status and control thanks to @miway80
adds a model property to the subdevice base class.
This could be used for the model to display in HomeAssistant device registry (could also use device_type_name, not sure what is better)
But more important this is needed in the future to easily add subscriptions to properties using the install_scripts of @bskaplou of PR #709