Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chuangmi_camera: Improve home monitoring support #751

Merged
merged 6 commits into from
Jul 8, 2020
Merged

chuangmi_camera: Improve home monitoring support #751

merged 6 commits into from
Jul 8, 2020

Conversation

impankratov
Copy link
Contributor

@impankratov impankratov commented Jul 4, 2020 •
edited
Loading

General:

  • fix error with rotate command (click.argument name wasn't matching method's argument name).

chuangmi.camera.ipc009 specific (maybe will work for other models too):

  • add motion sensitivity
  • add monitoring configuration
  • add methods for NAS configuration (get/set config, clear directory)

@coveralls
Copy link

coveralls commented Jul 4, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 74.002% when pulling 690fa63 on impankratov:feature/chuangmi-home-monitoring into 0155ebc on rytilahti:master.

rytilahti
rytilahti requested changes Jul 6, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me besides the statically defined arrays, thanks for the PR!

miio/chuangmi_camera.py Outdated
3,
3,
3,
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already defined as an enum below, so better simply use something like [enumvalue] * times to create the array when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice, fixed it.

@impankratov impankratov requested a review from rytilahti July 8, 2020 19:50
rytilahti
rytilahti approved these changes Jul 8, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 🎉

@rytilahti rytilahti changed the title Feature/chuangmi home monitoring chuangmi_camera: Improve home monitoring support Jul 8, 2020
@rytilahti rytilahti merged commit d1dd6b7 into rytilahti:master Jul 8, 2020
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@impankratov @xvlady
chuangmi_camera: Improve home monitoring support (rytilahti#751)
f7f120e 
* fix: camera rotation argument name

* add: set camera motion sensitivity

* add: camera monitoring config

* refactor: format

* add: NAS config methods

* fix: dynamically generated motion sensitivity arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impankratov @coveralls @rytilahti