-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for dmaker.fan.p11 #838
Conversation
hi, @rytilahti I don't know how to fix the pipeline, the test is passed in my local environment 😥, could you help to review the code? |
One reason that your new code fails to run in other environment is that Anyway, you can check error messages in the pipeline here |
I'm not sure that it will pass the test, but my suggestion is In the miot_spec_v2.py line 203, instead of add a blank _ _ init _ _.py file in miot_specs directory, if it is needed. |
@iquix not working ;( |
It looks like you hit this issue: lidatong/dataclasses-json#232 Can be reproduced locally if you run the tests with python 3.6. |
dmaker.fan.p11 is supported by #850 |
dmaker.fan.p11