Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miiocli: remove network & AP information from info output #857

Merged
merged 1 commit into from
Nov 5, 2020
Merged

miiocli: remove network & AP information from info output #857

merged 1 commit into from
Nov 5, 2020

Conversation

rytilahti
Copy link
Owner

This removes identifiable information from the info output to make it safer to paste the output on the internet:

  • AP information leaks geolocation
  • Network information leaks internal network structure

This affects only miiocli, if these infos are needed it is simple to use debug verbosity to check them.

@rytilahti rytilahti added the bug label Nov 5, 2020
@rytilahti rytilahti added this to the 0.5.4 milestone Nov 5, 2020
@syssi syssi merged commit 460a1d4 into master Nov 5, 2020
@rytilahti rytilahti deleted the fix/cli/simplify_info branch November 5, 2020 19:16
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@rytilahti @xvlady
Remove network & AP information from info printout (rytilahti#857)
9f24cce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@rytilahti @syssi