Add support for all Huizuo Lamps (w/ fans, heaters, and scenes) #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Changing "color_temp" instead of "level" during manipulation with color temperature
2. Updated based on PR#868
2. Add tests
syssi
reviewed
Dec 3, 2020
syssi
reviewed
Dec 3, 2020
syssi
reviewed
Dec 3, 2020
syssi
reviewed
Dec 3, 2020
|
Guys, RP is ready for review, if you have a time |
rytilahti
requested changes
Dec 27, 2020
rytilahti
changed the title
|
I accidentally saw that you requested two small changes. |
rytilahti
reviewed
Jan 8, 2021
|
Good catch! |
rytilahti
reviewed
Jan 8, 2021
Merged
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
…lahti#881) * Adding Huizuo basic support * Add huizuo.py to the repo * Update __init__.py to the latest version * Fix _LOGGER error * Enabling iSort in VSCode on Save * 1. Removed unnecessary click.argument calls 2. Changing "color_temp" instead of "level" during manipulation with color temperature * 1. Removed Huizuo from discovery - devices are not mdns discoverable 2. Updated based on PR#868 * Re-arranged color_temp parameter for better understanding * fixing linting issues * Added only example of JSON payload from the lamp * Updated README.rst, added separations * 1. Use MiotDevice class 2. Add tests * Fixing linting issues * Fixing linting issue - second try... * Processing comments from PR#868 * Updated the list of devices, updated status * fix wrong dict concatenation * Dict concat fix 2 * Update mapping and status output * Fix status issue * is_fan_reverse update * Added fan, heater, scene supports * Updated unit test * Update README.rst * Split by classes * Cut the basic status for lamp * pre-commit * Processing suggestions from PR#881 * Change the function name in scene management (request from PR rytilahti#881) * Simplifying code (removing unnecessary 'else' statements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by previous work (PR #868), I checked specifications for all HUIZUO lamps, mentioned in the #627 [meta] list of miot-enabled devices. In general, almost all of them have a similar schema for light management, and some models have additionally a fan, heater, or predefined scenes.
Code for additional features was written based on official specifications.