Replaced typing by pyyaml #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I'm not seeing that error myself, but typing is not indeed necessary as we don't support 3.5 at all. Could you also please add py39 also to the env list, and pyyaml to the docs environment (looks like something requires it, but I'm not sure what)? |
legacycode
force-pushed
the
fix-build
branch
from
32c3aed to
80fb0bf
Compare
legacycode
force-pushed
the
fix-build
branch
from
80fb0bf to
5815db3
Compare
|
I also added py39 to the azure ci file. |
|
Great, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using typing with python 3.8 i can not run tox. I am getting the following error:
AttributeError: type object 'Callable' has no attribute '_abc_registry'According to the documenation on https://pypi.org/project/typing/ typing should only by included in projects using python < 3.5. This pull request fixes my build.