Re-add mapping parameter to MiotDevice ctor #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the method signature is different from previous versions to accommodate the compatibility with Device ctor Fixes #982
rytilahti
force-pushed
the
fix/miotdevice_ctor_regression
branch
from
faeba0d to
ad7e4e4
Compare
Merged
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
Note that the method signature is different from previous versions to accommodate the compatibility with Device ctor Fixes rytilahti#982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the method signature is different from previous versions to accommodate the compatibility with the Device ctor.
Previous versions had a signature where the mapping was the first argument, now it is only allowed as a keyword-only argument:
and
are the the allowed ways to initialize a plain
MiotDeviceinstance.The implementations should not override the constructor to use this method to pass the mapping, but instead define
mappingas a class variable.Fixes #982