Add a base to allow easier testing of devices #99

rytilahti · 2017-10-21T17:17:07Z

To demonstrate its functionality unittests for yeelight and plug
are included in this commit. It also allowed to spot a couple of bugs
in yeelight already..

To demonstrate its functionality unittests for yeelight and plug are included in this commit. It also allowed to spot a couple of bugs in yeelight already..

houndci-bot · 2017-10-21T17:17:13Z

miio/tests/test_yeelight.py

+        assert name() == "new test name"
+
+    def test_toggle(self):
+        is_on = lambda: self.device.status().is_on


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:17:13Z

miio/tests/test_yeelight.py

+        assert new_state is orig_state
+
+    def test_set_name(self):
+        name = lambda: self.device.status().name


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:17:13Z

miio/tests/test_yeelight.py

+        assert new_mode is not dev_mode()
+
+    def test_set_save_state_on_change(self):
+        save_state = lambda: self.device.status().save_state_on_change


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:17:13Z

miio/tests/test_yeelight.py

+        self.device.set_hsv()
+
+    def test_set_developer_mode(self):
+        dev_mode = lambda: self.device.status().developer_mode


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:17:13Z

miio/tests/test_yeelight.py

+            self.device.set_brightness(200)
+
+    def test_set_color_temp(self):
+        color_temp = lambda: self.device.status().color_temp


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:17:14Z

miio/tests/test_yeelight.py

+        # assert status.hsv == (359, 100, 100)
+
+    def test_on(self):
+        self.device.off() # make sure we are off


at least two spaces before inline comment

houndci-bot · 2017-10-21T17:17:14Z

miio/tests/test_yeelight.py

+        assert status.color_temp == 3584
+        assert status.color_mode == YeelightMode.ColorTemperature
+        assert status.developer_mode == True
+        assert status.save_state_on_change == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-10-21T17:17:14Z

miio/tests/test_yeelight.py

+        assert status.brightness == 100
+        assert status.color_temp == 3584
+        assert status.color_mode == YeelightMode.ColorTemperature
+        assert status.developer_mode == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-10-21T17:17:14Z

miio/tests/test_yeelight.py

+        self.device._reset_state()
+        status = self.device.status()  # type: YeelightStatus
+        assert status.name == self.device.start_state["name"]
+        assert status.is_on == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-10-21T17:17:14Z

miio/tests/test_yeelight.py

+    request.cls.device = DummyLight()
+    # TODO add ability to test on a real device
+
+@pytest.mark.usefixtures("dummylight")


expected 2 blank lines, found 1

coveralls · 2017-10-21T17:19:49Z

Coverage increased (+5.8%) to 39.793% when pulling 3f6ed45 on add_unittest_base into ec71776 on master.

houndci-bot · 2017-10-21T17:21:23Z

miio/tests/test_yeelight.py

+import pytest
+from .dummies import DummyDevice
+
+class DummyLight(DummyDevice, Yeelight):


expected 2 blank lines, found 1

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_yeelight.py

@@ -0,0 +1,188 @@
+from unittest import TestCase
+from miio import Yeelight
+from miio.yeelight import YeelightMode, YeelightStatus, YeelightException


'miio.yeelight.YeelightStatus' imported but unused

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+
+    def test_status_without_current(self):
+        del self.device.state["current"]
+        state = lambda: self.device.status()


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+        print(state())
+        assert state().is_on == True
+        assert state().temperature == self.device.start_state["temperature"]
+        assert state().load_power ==  self.device.start_state["current"] * 110


multiple spaces after operator

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+        self.device._reset_state()
+        state = lambda: self.device.status()
+        print(state())
+        assert state().is_on == True


comparison to True should be 'if cond is True:' or 'if cond:'

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+        self.device.off()  # ensure off
+        is_on = lambda: self.device.status().is_on
+        start_state = is_on()
+        assert start_state == False


comparison to False should be 'if cond is False:' or 'if not cond:'

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+class TestPlug(TestCase):
+    def test_on(self):
+        self.device.off()  # ensure off
+        is_on = lambda: self.device.status().is_on


do not assign a lambda expression, use a def

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+
+@pytest.mark.usefixtures("plug")
+
+class TestPlug(TestCase):


blank lines found after function decorator

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+    request.cls.device = DummyPlug()
+    # TODO add ability to test on a real device
+
+@pytest.mark.usefixtures("plug")


expected 2 blank lines, found 1

houndci-bot · 2017-10-21T17:21:24Z

miio/tests/test_plug.py

+        }
+        super().__init__(args, kwargs)
+
+@pytest.fixture(scope="class")


expected 2 blank lines, found 1

coveralls · 2017-10-21T17:23:57Z

Coverage increased (+5.6%) to 39.604% when pulling 6dfd144 on add_unittest_base into ec71776 on master.

houndci-bot · 2017-10-21T17:24:00Z

miio/tests/test_plug.py

+
+    def test_status_without_current(self):
+        del self.device.state["current"]
+        def state():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+
+        assert state().is_on is True
+        assert state().temperature == self.device.start_state["temperature"]
+        assert state().load_power ==  self.device.start_state["current"] * 110


multiple spaces after operator

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+
+    def test_off(self):
+        self.device.on()  # ensure on
+        def is_on():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+        assert is_on() is True
+
+
+    def test_off(self):


too many blank lines (2)

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+class TestPlug(TestCase):
+    def test_on(self):
+        self.device.off()  # ensure off
+        def is_on():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+from .dummies import DummyDevice
+import pytest
+
+class DummyPlug(DummyDevice, Plug):


expected 2 blank lines, found 1

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+
+    def test_status_without_current(self):
+        del self.device.state["current"]
+        def state():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+
+        assert state().is_on is True
+        assert state().temperature == self.device.start_state["temperature"]
+        assert state().load_power ==  self.device.start_state["current"] * 110


multiple spaces after operator

houndci-bot · 2017-10-21T17:24:01Z

miio/tests/test_plug.py

+
+    def test_off(self):
+        self.device.on()  # ensure on
+        def is_on():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:02Z

miio/tests/test_plug.py

+        assert is_on() is True
+
+
+    def test_off(self):


too many blank lines (2)

houndci-bot · 2017-10-21T17:24:02Z

miio/tests/test_plug.py

+class TestPlug(TestCase):
+    def test_on(self):
+        self.device.off()  # ensure off
+        def is_on():


expected 1 blank line before a nested definition, found 0

houndci-bot · 2017-10-21T17:24:02Z

miio/tests/test_plug.py

+from .dummies import DummyDevice
+import pytest
+
+class DummyPlug(DummyDevice, Plug):


expected 2 blank lines, found 1

houndci-bot · 2017-10-21T17:27:18Z

miio/tests/test_plug.py

+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]
+        assert self.state().load_power == self.device.start_state["current"] * 110


line too long (82 > 79 characters)

houndci-bot · 2017-10-21T17:27:18Z

miio/tests/test_plug.py

+        self.device._reset_state()
+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temperature"]


line too long (81 > 79 characters)

coveralls · 2017-10-21T17:27:29Z

Coverage increased (+5.6%) to 39.596% when pulling 9e97677 on add_unittest_base into 61874e3 on master.

coveralls · 2017-10-21T17:29:35Z

Coverage increased (+5.5%) to 39.498% when pulling d7d8e52 on add_unittest_base into 61874e3 on master.

syssi · 2017-10-23T20:34:55Z

Cool! Could be merged. I will try to adopt the test for a air purifier soon!

Add a base to allow easier testing of devices

3f6ed45

To demonstrate its functionality unittests for yeelight and plug are included in this commit. It also allowed to spot a couple of bugs in yeelight already..

houndci-bot reviewed Oct 21, 2017

View reviewed changes

rytilahti force-pushed the add_unittest_base branch from 6dfd144 to 9e97677 Compare October 21, 2017 17:23

houndci-bot reviewed Oct 21, 2017

View reviewed changes

make hound happy again

d7d8e52

rytilahti force-pushed the add_unittest_base branch from 9e97677 to d7d8e52 Compare October 21, 2017 17:27

houndci-bot reviewed Oct 21, 2017

View reviewed changes

rytilahti merged commit c859d51 into master Oct 23, 2017

rytilahti deleted the add_unittest_base branch October 23, 2017 20:53


		@pytest.mark.usefixtures("plug")

		class TestPlug(TestCase):

Add a base to allow easier testing of devices #99

Add a base to allow easier testing of devices #99

Conversation

rytilahti commented Oct 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2017 • edited Loading

coveralls commented Oct 21, 2017 • edited Loading

syssi commented Oct 23, 2017

coveralls commented Oct 21, 2017 •

edited

Loading

coveralls commented Oct 21, 2017 •

edited

Loading

coveralls commented Oct 21, 2017 •

edited

Loading

coveralls commented Oct 21, 2017 •

edited

Loading