Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support lacks authentication settings #279

Closed
nox-4O4 opened this issue Apr 4, 2023 · 2 comments · Fixed by #338
Closed

Proxy support lacks authentication settings #279

nox-4O4 opened this issue Apr 4, 2023 · 2 comments · Fixed by #338
Labels
enhancement New feature or request. good first issue Good for newcomers. to grab Ready to do and to grab by those willing.

Comments

@nox-4O4
Copy link

nox-4O4 commented Apr 4, 2023

Some proxies require authentication. There are Maven settings to configure proxy credentials:
https://maven.apache.org/settings.html#proxies

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
  ...
  <proxies>
    <proxy>
      <id>myproxy</id>
      <active>true</active>
      <protocol>http</protocol>
      <host>proxy.somewhere.com</host>
      <port>8080</port>
      <username>proxyuser</username>
      <password>somepassword</password>
      <nonProxyHosts>*.google.com|ibiblio.org</nonProxyHosts>
    </proxy>
  </proxies>
  ...
</settings>

(username and password).

Currently, it is not possible to specify proxy authentification using proxies option.

@slawekjaranowski
Copy link
Member

PR are welcome

@slawekjaranowski slawekjaranowski added to grab Ready to do and to grab by those willing. good first issue Good for newcomers. labels Jul 20, 2023
Gozke added a commit to Gozke/maven-settings-action that referenced this issue Aug 3, 2024
@Gozke
Copy link
Contributor

Gozke commented Aug 3, 2024

Hi There,
I wanted to experiment a little with github actions and take a look into an existing one.. so I took the liberty of fixing this issue. See my PR here: #338.

This action's a greate initive. ;) Thanks for your work so far!

@slawekjaranowski slawekjaranowski linked a pull request Sep 5, 2024 that will close this issue
@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Nov 3, 2024
slawekjaranowski pushed a commit to Gozke/maven-settings-action that referenced this issue Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. good first issue Good for newcomers. to grab Ready to do and to grab by those willing.
Development

Successfully merging a pull request may close this issue.

3 participants