Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path argument so we can customize where settings.xml will be stored #183

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

pkruk
Copy link

@pkruk pkruk commented Feb 3, 2022

Hi

I would like to add path argument to your action, so I can decide where my settings.xml will be stored :)

I will be very glad for review and comments :)

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for collaboration.

I know it is simple change .. but for consequence please add simple test something like

 mySettings =  path.join(testHomePath, 'mypath,,,');
 process.env['INPUT_PATH'] = mySettings;
 
 settings.generate();

 and check if mySettings exist

@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Feb 3, 2022
@pkruk
Copy link
Author

pkruk commented Feb 4, 2022

Thanks for feedback :)! I added one test and squash commits :)!

@slawekjaranowski slawekjaranowski merged commit 654e1ef into s4u:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Development

Successfully merging this pull request may close these issues.

2 participants