Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed the attribute support for servers. #95

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Completed the attribute support for servers. #95

merged 5 commits into from
Feb 16, 2021

Conversation

awhitford
Copy link
Contributor

Note that password is optional because a privateKey may be used.
Resolves #92.

slawekjaranowski
slawekjaranowski requested changes Feb 16, 2021
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please add use case with new properties to settings.test.js
  • please update README to show new properties
  • please squash to one final commit

and thank you for PR

index.test.js Show resolved Hide resolved
@awhitford
Copy link
Contributor Author

awhitford commented Feb 16, 2021 •
edited
Loading

Can't you just squash on the merge? (Is the Allow squash merging option enabled under Settings > Options > Merge button?)

@slawekjaranowski slawekjaranowski merged commit cd16d84 into s4u:master Feb 16, 2021
@slawekjaranowski
Copy link
Member

@awhitford once again thanks you, I will prepare next version until week end

@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Feb 16, 2021
@awhitford awhitford deleted the servers branch February 16, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete attribute support for Servers, and Password is Optional
2 participants
@awhitford @slawekjaranowski