Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.2 - use bunshi #25

Merged
merged 7 commits into from
Sep 21, 2023
Merged

V1.2 - use bunshi #25

merged 7 commits into from
Sep 21, 2023

Conversation

loganvolkers
Copy link
Member

Description of the change

Replace the internals of jotai-molecules to use bunshi. This makes the modules interoperable, and provide a backwards-compatible and gradual adoption path from jotai-molecules to bunshi.

Should deploy after #24

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

@loganvolkers loganvolkers marked this pull request as ready for review September 21, 2023 20:23
00salmon
00salmon reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@00salmon 00salmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple minor things

CHANGELOG.md Outdated Show resolved Hide resolved
src/legacy/useMolecule.tsx Show resolved Hide resolved
@loganvolkers @00salmon
Update CHANGELOG.md
0a593dd 
Co-authored-by: Sam Beveridge <sam.beveridge@referralsaasquatch.com>
00salmon
00salmon approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@00salmon 00salmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ✅

@loganvolkers loganvolkers merged commit f814313 into 1.x Sep 21, 2023
@loganvolkers loganvolkers deleted the v1.2 branch September 21, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@00salmon 00salmon 00salmon approved these changes

@johanventer johanventer Awaiting requested review from johanventer

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loganvolkers @00salmon