Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: failing suspense test #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lazakrisz
Copy link

@lazakrisz lazakrisz commented Jun 8, 2024

Failing test case due to never resolving suspense boundary when using async atoms within molecules.

I added the failing test which is currently being discussed in #69 , currently this is just a draft pull request.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

@loganvolkers
Copy link
Member

Thanks for the PR @lazakrisz I'll take a look

@lazakrisz
Copy link
Author

Thanks for the PR @lazakrisz I'll take a look

No problem, I was also thinking whether this is an issue on bunshi's side or my app's side. I did a little bit more thorough explanation on the original issue: #69 (comment)
Since then I tried finding another library / reference which would show some more integration with React's Suspense, but I was unable to find any pointers.
let me know if there's anything else I can help with 🙏 I might also try some further debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants