Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency eslint-plugin-testing-library to v6 #1020

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 12, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-testing-library ^5.11.1 -> ^6.0.1 age adoption passing confidence

Release Notes

testing-library/eslint-plugin-testing-library (eslint-plugin-testing-library)

v6.0.1

Compare Source

Bug Fixes
  • no-await-sync-events: stop reporting user-event by default (#​803) (88246fc)

v6.0.0

Compare Source

You can follow the migration guide to v6.

BREAKING CHANGES
  • await-async-query: await-async-query is now called await-async-queries
  • no-await-sync-events: no-await-sync-events is now enabled by default in the DOM, Angular & React configs
  • no-await-sync-query: no-await-sync-query is now called no-await-sync-queries
  • no-debugging-utils: no-debugging-utils now enables all debug methods in all configs by default
  • no-node-access: no-node-access is now enabled by default in the DOM config
  • await-fire-event: await-fire-event is now called await-async-event
  • no-global-regexp-flag-in-query: no-global-regexp-flag-in-query is now enabled by default in all configs
  • no-manual-cleanup: no-manual-cleanup is now enabled by default in the React & Vue configs
  • no-render-in-setup: no-render-in-setup is now called no-render-in-lifecycle
  • prefer-wait-for: prefer-wait-for is now removed
Bug Fixes
Features
  • await-async-event: add basic fixer (#​656) (b4b5394)
  • await-async-query: rename to await-async-queries (#​665) (c1803df)
  • await-fire-event: rename to await-async-event + add support for user-event (#​652) (b4ce9bb)
  • no-await-sync-events: add to DOM, Angular & React configs by default (#​667) (afce5ea)
  • no-await-sync-query: rename to no-await-sync-queries (#​666) (7ed3da8)
  • no-debugging-utils: enable all debug methods in all configs by default (#​663) (e394ce0)
  • no-debugging-utils: warn instead of error in all configs (#​662) (8063f8f)
  • no-global-regexp-flag-in-query: add to all configs by default (#​660) (c76a7bf)
  • no-manual-cleanup: add to React & Vue configs by default (#​659) (8f6ebf5)
  • no-node-access: add to DOM config by default (#​661) (8dfe155)
  • no-render-in-setup: rename to no-render-in-lifecycle (#​649) (9acba43)
  • prefer-wait-for: remove rule (#​648) (20f23ad)

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 12, 2023
@renovate renovate bot requested a review from sabertazimi August 12, 2023 13:15
@socket-security
Copy link

socket-security bot commented Aug 12, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #1020 (fb5e529) into main (1a5c4ec) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           57        57           
  Branches         2         2           
=========================================
  Hits            57        57           

@renovate renovate bot force-pushed the renovate/eslint-plugin-testing-library-6.x branch from 87a29e8 to d19516b Compare August 24, 2023 16:25
@pull-request-quantifier-deprecated

This PR has 9 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -5
Percentile : 3.6%

Total files changed: 3

Change summary by file extension:
.js : +3 -4
.json : +1 -1
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sabertazimi sabertazimi merged commit d5037f8 into main Aug 26, 2023
11 checks passed
@sabertazimi sabertazimi deleted the renovate/eslint-plugin-testing-library-6.x branch August 26, 2023 10:04
github-actions bot added a commit that referenced this pull request Aug 26, 2023
* fix(deps): update dependency eslint-plugin-testing-library to v6
* fix(eslint-config): migrate to testing-library v6

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sabertazimi <sabertazimi@gmail.com> d5037f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant