Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate failing tests #289

Closed
smol-ninja opened this issue Oct 5, 2024 · 4 comments
Closed

Investigate failing tests #289

smol-ninja opened this issue Oct 5, 2024 · 4 comments
Assignees
@smol-ninja @andreivladbrg
Labels
effort: high Large or difficult task. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: bug Something isn't working. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@smol-ninja
Copy link
Member

@smol-ninja smol-ninja added effort: high Large or difficult task. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: bug Something isn't working. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Oct 5, 2024
@smol-ninja smol-ninja mentioned this issue Oct 13, 2024
Merged
@smol-ninja
Copy link
Member Author

Once again a failed invariant: https://github.com/sablier-labs/flow/actions/runs/11315197709/job/31466098930

@andreivladbrg have you made up your mind about invariant_TotalStreamedWithDelayEqTotalDebtPlusWithdrawn to test for inequality instead of equality?

@smol-ninja
Copy link
Member Author

IMO lets go with inequality now. The failing tests won't look well during the public contest. We understand the problem, what is causing it but due to uncertainty in wei lost in a stream (1 / 2 amount), we are not able to pin point a concrete solution. The inequality guarantees that the precision error is within a limit.

Lets create another issue to track a concrete solution for this problem.

@andreivladbrg
Copy link
Member

tests won't look well during the public contest

agree, let’s temporarily remove the delay logic in the invariant; i’ll think of a way to properly test equality (if it is possible) this after the audit. the inequality works as well

@smol-ninja smol-ninja mentioned this issue Oct 14, 2024
Closed
@smol-ninja
Copy link
Member Author

Closing this as it should have been resolved by #315.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

@andreivladbrg andreivladbrg

Labels
effort: high Large or difficult task. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: bug Something isn't working. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @andreivladbrg