Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace the delay logic from invariant with an inequality #307

Closed
smol-ninja opened this issue Oct 14, 2024 · 0 comments · Fixed by #315
Closed

replace the delay logic from invariant with an inequality #307

smol-ninja opened this issue Oct 14, 2024 · 0 comments · Fixed by #315
Assignees
@andreivladbrg
Labels
effort: medium Default level of effort. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

As discussed in #289, remove the delay logic from invariant_TotalStreamedWithDelayEqTotalDebtPlusWithdrawn and use inequality as follows:

  • approximately assert that "totalStreamedAmount = flow.totalDebtOf(streamId) + flowStore.withdrawnAmounts(streamId)" with a delta of 10 wei.
@smol-ninja smol-ninja added priority: 0 Do this first before everything else. This is critical and nothing works without this. effort: medium Default level of effort. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. type: test Adding, updating, or removing tests. labels Oct 14, 2024
@smol-ninja smol-ninja self-assigned this Oct 14, 2024
@andreivladbrg andreivladbrg mentioned this issue Oct 15, 2024
Merged
@andreivladbrg andreivladbrg mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: medium Default level of effort. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: inequality in streamed amount invariant sablier-labs/flow
2 participants
@smol-ninja @andreivladbrg