Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: import BaseScript from core #315

Closed
wants to merge 1 commit into from
Closed

refactor: import BaseScript from core #315

wants to merge 1 commit into from

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Apr 9, 2024 •
edited
Loading

@PaulRBerg
Copy link
Member

Thanks for this PR, but I will close it because I am against including the BaseScript in the npm package.

@PaulRBerg PaulRBerg closed this Apr 9, 2024
@smol-ninja smol-ninja deleted the refactor/basescript-core branch April 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg Awaiting requested review from PaulRBerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @PaulRBerg