Include "before" and "after" copy events as with move events #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
There should be unit tests for event handling. Please have a look and extend the tests. Thx 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #1396 +/- ##
============================================
- Coverage 97.19% 97.07% -0.12%
+ Complexity 2826 2820 -6
============================================
Files 175 175
Lines 8352 7703 -649
============================================
- Hits 8118 7478 -640
+ Misses 234 225 -9
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jvillafanez
force-pushed
the
explicit_copy_events
branch
from
f9c9d7d to
5f6e466
Compare
jvillafanez
force-pushed
the
explicit_copy_events
branch
from
5f6e466 to
347e775
Compare
|
I don't think I can rise the project coverage taking into account that the patch has 100% coverage. There might be tests missing outside of the scope of this PR. |
DeepDiver1975
approved these changes
Mar 31, 2022
|
@DeepDiver1975 merging? |
This was referenced Jun 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same way "beforeMove" and "afterMove" events are triggered, the new "beforeCopy" and "afterCopy" events will be triggered during a COPY request.