explicitly cast content length to int #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
approved these changes
Jun 13, 2017
|
Not just the unit tests also the output of assets. There is a good reason to have unit tests and keep an eye on the if they succeed or fail. |
|
I wanted to provide the same change. Can you rebase / fix the conflict so the merge can be done? |
evert
approved these changes
Aug 7, 2017
|
Please rebase/resplve conflicts, atm not mergable as is |
icewind1991
force-pushed
the
cast-content-length
branch
from
46836df to
40801fa
Compare
|
rebased |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else the unit tests fail with php7