Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI for PHP 8.4 #122

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 4, 2024

Similar to what was done for the v2 branch for release https://github.com/sabre-io/uri/releases/tag/2.3.4
Code from #116 and #117
And adjust phpstan config like in #120
For now, I am ignoring phpstan "errors" like: * will always evaluate to true
because it is telling that the code is overly cautious, and I will leave the overly-cautious code as it does no harm.

This now confirms in CI that everything is passing for PHP 8.4 in the master branch.

There are no actual code changes, so I will look to see what else has happened in the master branch since the latest 3.0.1 release. If there are code changes waiting, then I will make release 3.0.2

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (254a670) to head (5639795).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files           1        1           
  Lines         174      174           
=======================================
  Hits          170      170           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis self-assigned this Sep 4, 2024
@phil-davis phil-davis marked this pull request as ready for review September 4, 2024 15:11
@phil-davis phil-davis merged commit 1718709 into sabre-io:master Sep 4, 2024
6 checks passed
@phil-davis phil-davis deleted the update-ci-20240904 branch September 4, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant