Skip to content

Commit

Permalink
Load other font weights and styles for the body-font (bigcommerce#2396)
Browse files Browse the repository at this point in the history
* Load other font weights and styles for the body-font

Using a font name like `Google_Karla_400` for `body-font`, it would
only load the 400 font weight. When using `Google_Karla_700` for
another property, it would then load both the 400 and 700 fon weights.
But since in CSS you could make something bold or italic, the font
weight and/or style for this text might be missing, as it was not
loaded automatically by using it in another property.

This PR will make sure that the most common font weights and font
styles will be loaded for the body font.

* Update CHANGELOG.md

---------

Co-authored-by: Volodymyr Krasnoshapka <88093058+BC-krasnoshapka@users.noreply.github.com>
  • Loading branch information
2ndkauboy and BC-krasnoshapka authored Jul 4, 2024
1 parent 478eb2e commit 8090f58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Prevent flow outside page container on account pages [#2462](https://github.com/bigcommerce/cornerstone/pull/2462)
- Account.js - Fixed jquery selector to be template literal [#2464](https://github.com/bigcommerce/cornerstone/pull/2464)
- Address deprecated jQuery methods [#2466](https://github.com/bigcommerce/cornerstone/pull/2466)
- Load other font weights and styles for the body-font [#2396](https://github.com/bigcommerce/cornerstone/pull/2396)

## 6.14.0 (05-15-2024)
- Account.php <a href> is inside of a list item [#2457](https://github.com/bigcommerce/cornerstone/pull/2457)
Expand Down
2 changes: 1 addition & 1 deletion config.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"default_image_brand": "img/BrandDefault.gif",
"default_image_product": "img/ProductDefault.gif",
"default_image_gift_certificate": "img/GiftCertificate.png",
"body-font": "Google_Karla_400",
"body-font": "Google_Karla_400,400i,700,700i",
"headings-font": "Google_Montserrat_400",
"fontSize-root": 14,
"fontSize-h1": 28,
Expand Down

0 comments on commit 8090f58

Please sign in to comment.