forked from bigcommerce/cornerstone
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(storefront): BCTHEME-373 Alt text not provided for ratings (bigc…
- Loading branch information
1 parent
2d30e32
commit d24b3c0
Showing
5 changed files
with
37 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,16 @@ | ||
{{#for 1 5}} | ||
{{#if ../this.rating '>=' $index}} | ||
<span class="icon icon--ratingFull"> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="28" viewBox="0 0 26 28"><path d="M0 10.11q0-.58.875-.72L8.72 8.25l3.515-7.11Q12.532.5 13 .5t.767.64l3.516 7.11 7.844 1.14q.875.14.875.72 0 .343-.406.75l-5.672 5.53 1.344 7.812q.016.11.016.313 0 .328-.164.555t-.477.227q-.297 0-.625-.187l-7.016-3.687-7.016 3.687q-.344.187-.625.187-.327 0-.49-.227t-.165-.555q0-.094.03-.313L6.08 16.39.392 10.86q-.39-.423-.39-.75z"/></svg> | ||
</span> | ||
{{else}} | ||
<span class="icon icon--ratingEmpty"> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="28" viewBox="0 0 26 28"><path d="M0 10.11q0-.58.875-.72L8.72 8.25l3.515-7.11Q12.532.5 13 .5t.767.64l3.516 7.11 7.844 1.14q.875.14.875.72 0 .343-.406.75l-5.672 5.53 1.344 7.812q.016.11.016.313 0 .328-.164.555t-.477.227q-.297 0-.625-.187l-7.016-3.687-7.016 3.687q-.344.187-.625.187-.327 0-.49-.227t-.165-.555q0-.094.03-.313L6.08 16.39.392 10.86q-.39-.423-.39-.75z"/></svg> | ||
</span> | ||
{{/if}} | ||
{{/for}} | ||
<span role="img" | ||
alt="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}" | ||
title="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}" | ||
> | ||
{{#for 1 5}} | ||
{{#if ../this.rating '>=' $index}} | ||
<span class="icon icon--ratingFull"> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="28" viewBox="0 0 26 28"><path d="M0 10.11q0-.58.875-.72L8.72 8.25l3.515-7.11Q12.532.5 13 .5t.767.64l3.516 7.11 7.844 1.14q.875.14.875.72 0 .343-.406.75l-5.672 5.53 1.344 7.812q.016.11.016.313 0 .328-.164.555t-.477.227q-.297 0-.625-.187l-7.016-3.687-7.016 3.687q-.344.187-.625.187-.327 0-.49-.227t-.165-.555q0-.094.03-.313L6.08 16.39.392 10.86q-.39-.423-.39-.75z"/></svg> | ||
</span> | ||
{{else}} | ||
<span class="icon icon--ratingEmpty"> | ||
<svg xmlns="http://www.w3.org/2000/svg" width="26" height="28" viewBox="0 0 26 28"><path d="M0 10.11q0-.58.875-.72L8.72 8.25l3.515-7.11Q12.532.5 13 .5t.767.64l3.516 7.11 7.844 1.14q.875.14.875.72 0 .343-.406.75l-5.672 5.53 1.344 7.812q.016.11.016.313 0 .328-.164.555t-.477.227q-.297 0-.625-.187l-7.016-3.687-7.016 3.687q-.344.187-.625.187-.327 0-.49-.227t-.165-.555q0-.094.03-.313L6.08 16.39.392 10.86q-.39-.423-.39-.75z"/></svg> | ||
</span> | ||
{{/if}} | ||
{{/for}} | ||
</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
{{#for 1 5}} | ||
{{#if ../this.rating '>=' $index}} | ||
<span class="icon icon--ratingFull"> | ||
<svg> | ||
<use xlink:href="#icon-star" /> | ||
</svg> | ||
</span> | ||
{{else}} | ||
<span class="icon icon--ratingEmpty"> | ||
<svg> | ||
<use xlink:href="#icon-star" /> | ||
</svg> | ||
</span> | ||
{{/if}} | ||
{{/for}} | ||
<span role="img" | ||
alt="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}" | ||
title="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}" | ||
> | ||
{{#for 1 5}} | ||
{{#if ../this.rating '>=' $index}} | ||
<span class="icon icon--ratingFull"> | ||
<svg> | ||
<use xlink:href="#icon-star" /> | ||
</svg> | ||
</span> | ||
{{else}} | ||
<span class="icon icon--ratingEmpty"> | ||
<svg> | ||
<use xlink:href="#icon-star" /> | ||
</svg> | ||
</span> | ||
{{/if}} | ||
{{/for}} | ||
</span> |