Separate Cypress tests into separate groups #927
Conversation
.github/workflows/ci.yml
Outdated
| @@ -94,9 +94,17 @@ jobs: | |||
| # fix for forcing git to use https when pulling deps | |||
| - run: 'git config --global --replace-all url."https://github.com/".insteadOf ssh://git@github.com/' | |||
| - run: npm ci | |||
| - run: npm run cy:coverage | |||
| - name: stateful tests | |||
There was a problem hiding this comment.
these steps will run back to back - it may be better to define a separate job for these so they can each have their own machine. If we do this then we won't necessarily need to use the parallel flag since we're basically manually parallelizing
There was a problem hiding this comment.
That makes sense. Gonna make the changes after figuring out the correct keywords. Apparently I'm using with incorrectly.
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
===========================================
- Coverage 67.83% 12.29% -55.54%
===========================================
Files 125 126 +1
Lines 3830 3928 +98
Branches 1165 1204 +39
===========================================
- Hits 2598 483 -2115
- Misses 1210 3445 +2235
+ Partials 22 0 -22
Continue to review full report at Codecov.
|
nguyenaiden
force-pushed
the
integration-test-group
branch
3 times, most recently
from
293f790 to
aa18683
Compare
nguyenaiden
changed the title
nguyenaiden
force-pushed
the
integration-test-group
branch
from
ab83e07 to
7eb677d
Compare
package-lock.json
Outdated
| @@ -5,7 +5,6 @@ | |||
| "requires": true, | |||
| "packages": { | |||
| "": { | |||
| "name": "saddle-frontend", | |||
There was a problem hiding this comment.
👀 not really sure why this happens but please rm from PR
.github/workflows/ci.yml
Outdated
| - 8545:8545 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
we can probably just remove matrix altogether if it's being run on one server
nguyenaiden
force-pushed
the
integration-test-group
branch
2 times, most recently
from
5d65b1d to
96b6786
Compare
Run both groups in parallel Readded lost changes Readded package del and removed integration folder
Readded repo name to package-lock.json
Update relative paths Fixed syntax
Increased deposit wait for app to 5 secs
nguyenaiden
force-pushed
the
integration-test-group
branch
from
1c9dd04 to
e1f0bd0
Compare
alphastorm
force-pushed
the
master
branch
2 times, most recently
from
5a3f5c3 to
5b44a67
Compare
Description: Currently, Cypress integration tests are slow because they're all running serially. The solution is to separate tests into groups - stateful and stateless, with the latter one running in parallel::
This change also requires ci.yml to be updated to accommodate the changes.
Related ticket