Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): update to 0.19.0 #11

Merged
merged 132 commits into from
Jul 15, 2024
Merged

chore(api): update to 0.19.0 #11

merged 132 commits into from
Jul 15, 2024

Conversation

dcorral
Copy link

@dcorral dcorral commented Jul 10, 2024

No description provided.

twosatsmaxi and others added 30 commits April 2, 2024 20:02
Previously, we were checking if an etching commit transaction had matured by
asking bitcoind how many confirmations it had. This was incorrect, because if
ord was behind bitcoind, the number of confirmations would be based on
bitcoind's current block height, and would be greater than the number of
confirmations the commit transaction had as of the reveal transaction block
height.

This commit fixes this by calculating the number of confirmations using the
block height of the commit transaction, which is correct even if bitcoind is
ahead.
This allows inscribing only the delegate without having to specify a file. In the batch it allows you to comletely omit the file as well.
Future runes features may be opt-in, for example, if they increase light client
validation costs, or if they are simply too degenerate.

This commit adds a "turbo" flag, which, if set, premptively opts in to such
future features.

It also sets the "turbo" flag on the genesis rune, UNCOMMON•GOODS.

Because the genesis rune is inserted into the index when it is created, the
schema version is also incremented, to force rebuilding indices created before
this commit.
Document that data push opcodes 0 through 78 inclusive are allowed in
runestones, and opcodes 79 and above will produce a cenotaph. Also add a test
that makes sure that this is actually true.
Ord now requires Rust 1.74 to build, update `rust-version` in Cargo.toml files
to reflect this.
Test that if the `cap` field of an etching is unset, it is treated as being
zero, and the rune is unmintable.Test that if the `cap` field of an etching is
unset, it is treated as being zero, and the rune is unmintable.
- Bump version: 0.17.1 → 0.18.0
- Update changelog
- Update changelog contributor credits
- Update dependencies
ordinals#3515)

While waiting to broadcast a rune etching, take into account the fact that the
commit transaction will have an additional confirmation in the next block.
Previously we weren't, so the wallet was waiting for one confirmation too many.
- Bump version: 0.18.0 → 0.18.1
- Update changelog
- Update changelog contributor credits
Don't allow etching if the etching reveal height is below the runes activation
height, otherwise the user would waste funds on an ineffective etching.
@dcorral dcorral marked this pull request as draft July 10, 2024 09:10
@dcorral dcorral changed the base branch from master to ordzaar-master July 10, 2024 09:12
@dcorral dcorral changed the base branch from ordzaar-master to ordzaar-master-0-18-5 July 10, 2024 19:58
@dcorral dcorral marked this pull request as ready for review July 10, 2024 19:59
@dcorral dcorral changed the base branch from ordzaar-master-0-18-5 to ordzaar-master July 10, 2024 20:01
Copy link
Collaborator

@danadi7 danadi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danadi7 danadi7 merged commit e5e45ce into ordzaar-master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.