Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene Symbols from Ensembl or custom source + better handling of identifiers and orthology translation #121

Merged
merged 5 commits into from
May 14, 2024

Conversation

deeenes
Copy link
Member

@deeenes deeenes commented May 9, 2024

Hi @PauBadiaM,

Here I implemented the stuff that the email discussion was about, now the user has 5 choices:

  • Use the gene symbols from the web service (the original behaviour)
  • Update them from Ensembl
  • Update them from UniProt
  • Provide a dict[str, set[str]] with any custom mapping
  • Use UniProt IDs instead of gene symbols

I checked all omnip.get_* functions with various options, and everything looks alright for me. If you agree, feel free to merge this to main.

@deeenes deeenes requested a review from PauBadiaM May 9, 2024 19:52
@deeenes deeenes self-assigned this May 9, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better bump to 1.6.2

Copy link
Collaborator

@PauBadiaM PauBadiaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Denes, thanks for the changes!
Looks fantastic but could you have a look at the build error? With the new changes, whenever a user types an unsupported organism they get a rather obscure error message TypeError: object of type 'NoneType' has no len() compared to the previous version.

@deeenes
Copy link
Member Author

deeenes commented May 10, 2024

That particular error I've just fixed in pypath a few days ago; however, I expect another error due to OMA API change, that too will be fixed very soon.

@PauBadiaM PauBadiaM merged commit b9e89cb into main May 14, 2024
1 of 2 checks passed
@PauBadiaM PauBadiaM deleted the genesymbols branch June 20, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants