Fix Zerion getCollectibles items count attribute (#1193)

- Set the `count` attribute to `null` on Zerion's collectibles retrieval. - Adapt the associated tests.
safe-global · Feb 22, 2024 · 9194172 · 9194172
1 parent 7ca6203
commit 9194172
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/datasources/balances-api/zerion-balances-api.service.ts b/src/datasources/balances-api/zerion-balances-api.service.ts
@@ -136,10 +136,10 @@ export class ZerionBalancesApi implements IBalancesApi {
         expireTimeSeconds: this.defaultExpirationTimeInSeconds,
       });
 
-      // TODO: Zerion does not provide the items count. Change this value to null when count attribute becomes nullable.
+      // Zerion does not provide the items count.
       // Zerion does not provide a "previous" cursor.
       return {
-        count: zerionCollectibles.data.length,
+        count: null,
         next: this._decodeZerionPagination(zerionCollectibles.links.next ?? ''),
         previous: null,
         results: this._mapCollectibles(zerionCollectibles.data),

diff --git a/src/routes/collectibles/__tests__/controllers/zerion-collectibles.controller.spec.ts b/src/routes/collectibles/__tests__/controllers/zerion-collectibles.controller.spec.ts
@@ -142,7 +142,7 @@ describe('Zerion Collectibles Controller', () => {
           .expect(200)
           .expect(({ body }) => {
             expect(body).toMatchObject({
-              count: zerionApiCollectiblesResponse.data.length,
+              count: null,
               next: expect.any(String),
               previous: null,
               results: [
@@ -282,7 +282,7 @@ describe('Zerion Collectibles Controller', () => {
           .expect(200)
           .expect(({ body }) => {
             expect(body).toMatchObject({
-              count: zerionApiCollectiblesResponse.data.length,
+              count: null,
               next: expect.stringContaining(expectedNext),
               previous: null,
               results: expect.any(Array),
@@ -345,7 +345,7 @@ describe('Zerion Collectibles Controller', () => {
           .expect(200)
           .expect(({ body }) => {
             expect(body).toMatchObject({
-              count: zerionApiCollectiblesResponse.data.length,
+              count: null,
               next: expect.stringContaining(expectedNext),
               previous: null,
               results: expect.any(Array),
@@ -407,7 +407,7 @@ describe('Zerion Collectibles Controller', () => {
           .expect(200)
           .expect(({ body }) => {
             expect(body).toMatchObject({
-              count: zerionApiCollectiblesResponse.data.length,
+              count: null,
               next: expect.stringContaining(expectedNext),
               previous: null,
               results: expect.any(Array),