Update locking API network interface (#1293)

This updates the `LockingApi` methods to align with the object arguments of the networking interface: - Update `LockingApi['getRank']` - Update `LockingApi['getLeaderboard']`
safe-global · Mar 13, 2024 · a6a5cb6 · a6a5cb6
1 parent ea1e4da
commit a6a5cb6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/src/datasources/locking-api/locking-api.service.ts b/src/datasources/locking-api/locking-api.service.ts
@@ -27,7 +27,7 @@ export class LockingApi implements ILockingApi {
   async getRank(safeAddress: `0x${string}`): Promise<Rank> {
     try {
       const url = `${this.baseUri}/api/v1/leaderboard/${safeAddress}`;
-      const { data } = await this.networkService.get<Rank>(url);
+      const { data } = await this.networkService.get<Rank>({ url });
       return data;
     } catch (error) {
       throw this.httpErrorFactory.from(error);
@@ -40,10 +40,13 @@ export class LockingApi implements ILockingApi {
   }): Promise<Page<Rank>> {
     try {
       const url = `${this.baseUri}/api/v1/leaderboard`;
-      const { data } = await this.networkService.get<Page<Rank>>(url, {
-        params: {
-          limit: args.limit,
-          offset: args.offset,
+      const { data } = await this.networkService.get<Page<Rank>>({
+        url,
+        networkRequest: {
+          params: {
+            limit: args.limit,
+            offset: args.offset,
+          },
         },
       });
       return data;

diff --git a/src/routes/locking/locking.controller.spec.ts b/src/routes/locking/locking.controller.spec.ts
@@ -74,7 +74,7 @@ describe('Locking (Unit)', () => {
   describe('GET rank', () => {
     it('should get the rank', async () => {
       const rank = rankBuilder().build();
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard/${rank.holder}`:
             return Promise.resolve({ data: rank, status: 200 });
@@ -106,7 +106,7 @@ describe('Locking (Unit)', () => {
     it('should validate the response', async () => {
       const safeAddress = getAddress(faker.finance.ethereumAddress());
       const rank = { invalid: 'rank' };
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard/${safeAddress}`:
             return Promise.resolve({ data: rank, status: 200 });
@@ -134,7 +134,7 @@ describe('Locking (Unit)', () => {
         types: ['clientError', 'serverError'],
       });
       const errorMessage = faker.word.words();
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard/${safeAddress}`:
             return Promise.reject(
@@ -166,7 +166,7 @@ describe('Locking (Unit)', () => {
       const leaderboard = pageBuilder()
         .with('results', [rankBuilder().build()])
         .build();
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard`:
             return Promise.resolve({ data: leaderboard, status: 200 });
@@ -192,7 +192,7 @@ describe('Locking (Unit)', () => {
       const leaderboard = pageBuilder()
         .with('results', [{ invalid: 'rank' }])
         .build();
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard`:
             return Promise.resolve({ data: leaderboard, status: 200 });
@@ -219,7 +219,7 @@ describe('Locking (Unit)', () => {
         types: ['clientError', 'serverError'],
       });
       const errorMessage = faker.word.words();
-      networkService.get.mockImplementation((url) => {
+      networkService.get.mockImplementation(({ url }) => {
         switch (url) {
           case `${lockingBaseUri}/api/v1/leaderboard`:
             return Promise.reject(