Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ProxyFactoryDecoder #1139

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Add tests for ProxyFactoryDecoder #1139

merged 3 commits into from
Feb 14, 2024

Conversation

iamacook
Copy link
Member

This adds tests for the decodeFunctionData method of the ProxyFactoryDecoder.

@iamacook iamacook self-assigned this Feb 13, 2024
@iamacook iamacook requested a review from a team as a code owner February 13, 2024 11:35
@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7899403985

Details

  • 0 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.254%

Totals Coverage Status
Change from base Build 7885845745: 0.1%
Covered Lines: 5835
Relevant Lines: 6123

💛 - Coveralls

@fmrsabino fmrsabino added the in review Someone is reviewing this Pull Request label Feb 14, 2024
@fmrsabino fmrsabino removed the in review Someone is reviewing this Pull Request label Feb 14, 2024
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

const data = createProxyWithNonce.encode();

const expectedArgs = createProxyWithNonce.build();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

Suggested change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 2b75f62.

Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@iamacook iamacook merged commit 0fb7a05 into main Feb 14, 2024
16 checks passed
@iamacook iamacook deleted the proxy-factory-tests branch February 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants