Remove usage of UrlGeneratorHelper #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
previously approved these changes
Feb 19, 2024
Pull Request Test Coverage Report for Build 7974010876Details
💛 - Coveralls |
Removes the usage of `UrlGeneratorHelper` in `alerts.controller.spec.ts`. With its removal, it is now easier to catch potential issues around the URL generation that we return to the clients (i.e.: by decoupling the assertions from the implementation).
fmrsabino
force-pushed
the
remove-url-generator-helper-tests
branch
from
e39db73
to
6a87120
Compare
iamacook
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the usage of
UrlGeneratorHelperinalerts.controller.spec.ts. With its removal, it is now easier to catch potential issues around the URL generation that we return to the clients (i.e.: by decoupling the assertions from the implementation).