Propagate Django error messages from Transaction Service #1226
Conversation
| const httpErrorFactory = { | ||
| from: jest.fn(), | ||
| } as jest.MockedObjectDeep<HttpErrorFactory>; | ||
| const mockHttpErrorFactory = jest.mocked(httpErrorFactory); |
There was a problem hiding this comment.
I migrated to using the real HttpErrorFactory as we were mocking and testing the mocked functionality which didn't make much sense. Would welcome your thoughts regarding this.
Pull Request Test Coverage Report for Build 8100115384Details
💛 - Coveralls |
| // Map Django error as "standard" error message if present | ||
| const djangoError = get(error.data, 'nonFieldErrors[0]'); | ||
| if (djangoError) { | ||
| return new NetworkResponseError(error.url, error.response, { | ||
| message: djangoError, | ||
| }); |
There was a problem hiding this comment.
Nit: should we abstract from the technology used by the data source? I mean, what about changing the django references here and in the tests for another generic concept like transactionService?
There was a problem hiding this comment.
And also other nits:
nonFieldErrors[0]might be extracted to a class constant, wdyt?- This assumes we are only interested in the first error in the payload, aren't we? I'm ok with this as long as this is ok for the clients.
There was a problem hiding this comment.
I generalised all references to "Django" (preferring "Transaction Service") in 931505d, as well as moving the path to a constant. I also added a comment explaining the reasoning for returning the first error element - a string is preferred.
Summary
This adds an error mapper to the
TransactionApiservice that maps Django error messages (nonFieldErrors[0]) if present to be the "standard" errormessage.Changes
TransactionApi['mapError']and use it within all callsTransactionApi