-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Collectible
to zod
#1260
Conversation
Pull Request Test Coverage Report for Build 8230500960Details
💛 - Coveralls |
tokenSymbol: z.string(), | ||
logoUri: z.string(), | ||
id: z.string(), | ||
// AJV remnant - do not use format: 'uri' as it fails on some payloads that should be considered valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: do you think the AJV reference is needed? We could just comment out that we don't enforce URL validation here, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the comment in 01237f5 but I think we should revisit this in the future. If we can make the schemas stricter, it would be beneficial.
Summary
This migrates the validation of
Collectible
tozod
.Changes
CollectiblesValidator
and associated schemaCollectibleSchema
and infers type(s) from it