New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate `CreateDelegateDto` to `zod` #1262

Merged

iamacook merged 1 commit into main from zod-create-delegate-dto-validation

Mar 6, 2024

Member

iamacook commented Mar 6, 2024 •

edited

Loading

Summary

This migrates the validation of ContCreateDelegateDtoract to zod.

Changes

Removes CreateDelegateDtoValidationPipe and associated schema
Adds CreateDelegateDtoValidationPipe and infers type from it
Propagate required changes in codebase
Update associated tests


          Migrate CreateDelegateDto to zod

39fb42b

iamacook self-assigned this

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8172989727

Details

10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 93.195%

Totals
Change from base Build 8172013728:	0.06%
Covered Lines:	6438
Relevant Lines:	6667

💛 - Coveralls

iamacook marked this pull request as ready for review

March 6, 2024 13:54

iamacook requested a review from a team as a code owner

March 6, 2024 13:54

hectorgomezv approved these changes

View reviewed changes

iamacook merged commit 23f8557 into main

16 checks passed

iamacook deleted the zod-create-delegate-dto-validation branch

March 6, 2024 16:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet