-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Order entity to Zod #1280
Conversation
Uses Zod instead of AJV to validate and convert the Swap Order payload to an `Order` type.
Pull Request Test Coverage Report for Build 8246824940Details
💛 - Coveralls |
kind: z.union([z.literal('buy'), z.literal('sell')]), | ||
partiallyFillable: z.boolean(), | ||
sellTokenBalance: z.union([ | ||
z.literal('erc20'), | ||
z.literal('internal'), | ||
z.literal('external'), | ||
]), | ||
buyTokenBalance: z.union([z.literal('erc20'), z.literal('internal')]), | ||
signingScheme: z.union([ | ||
z.literal('eip712'), | ||
z.literal('ethsign'), | ||
z.literal('presign'), | ||
z.literal('eip1271'), | ||
]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as class
, status
, onchainOrderData.placementError
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done in 3c33daf
Co-authored-by: Aaron Cook <aaron@safe.global>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Uses Zod instead of AJV to validate and convert the Swap Order payload to an
Order
type.