Change relay-related errors to throw client-side errors #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmrsabino
approved these changes
Mar 11, 2024
| export class InvalidMultiSendError extends Error { | ||
| import { HttpException, HttpStatus } from '@nestjs/common'; | ||
|
|
||
| export class InvalidMultiSendError extends HttpException { |
There was a problem hiding this comment.
Since the status is known, maybe we can extend UnprocessableEntityException. No strong opinion here though.
(same for the others but with their respective exceptions classes).
There was a problem hiding this comment.
I wasn't aware of that! I changed it in 6e5c04c. There doesn't seem to be one for 429 though.
Pull Request Test Coverage Report for Build 8236133889Details
💛 - Coveralls |
hectorgomezv
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the relay-specific errors from extending
Errors toHttpException/UnprocessableEntityExceptions in order to specify astatus. By specifying thestatus, theRouteLoggerInteceptorcan extract it.Changes
The following exceptions have been changed to extend
HttpExceptions with aHttpStatusorUnprocessableEntityExceptionaccordingly:InvalidMultiSendErrorInvalidTransferErrorRelayLimitReachedErrorUnofficialMasterCopyErrorUnofficialMultiSendErrorUnofficialProxyFactoryError