Allow relaying of all ERC-20 methods #1288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This facilitates the relaying of all ERC-20 methods, with validation of
transfer
andtransferFrom
methods:transfer
transactions that are being executed to 'self' (the Safe) cannot be relayed.transferFrom
transactions that are being executed to 'self' or transferring from thesender
toreceiver
cannot be relayed.Motivation
We were previous only allowing "valid"
transfer
relays. It was otherwise not possible to relay other methods.This is an inherent bug that was ported over from the relay service - it was only validating
transfer
calldata. Other methods were able to relay as they passed the 'self'-validation.Note: although there is no validation of
transferFrom
on the relay service, adding it aligns with that oftransfer
.Changes
transferFrom
relaysIEncoder
s for mocking calldata