Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move viem deprecated getFunctionSelector to toFunctionSelector #1303

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Move viem deprecated getFunctionSelector to toFunctionSelector #1303

merged 1 commit into from
Mar 14, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

The function getFunctionSelector was deprecated in viem 2.4.0. See: https://github.com/wevm/viem/blob/main/src/CHANGELOG.md#minor-changes-4

Changes

  • Moves deprecated getFunctionSelector calls to toFunctionSelector.

@hectorgomezv hectorgomezv self-assigned this Mar 14, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner March 14, 2024 15:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8283494944

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 93.66%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8281603280: 0.0%
Covered Lines: 6376
Relevant Lines: 6580
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 4fdc117 into main Mar 14, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the remove-deprecated-viem-function branch March 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectorgomezv @coveralls @fmrsabino @iamacook