Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing path safeAddress param on Swagger locking docs #1318

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

iamacook
Copy link
Member

Summary

The {safeAddress} path params for the locking endpoints were not showing on Swagger. This explicitly defines the types of the params so that they now appear in the docs and can be tested:

image

image

Changes

  • Switch from Zod's inferral to explicit 0x${string} type

@iamacook iamacook self-assigned this Mar 18, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8327365804

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 93.637%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.98%
Totals Coverage Status
Change from base Build 8327037169: -0.03%
Covered Lines: 6505
Relevant Lines: 6712

💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review March 18, 2024 13:29
@iamacook iamacook requested a review from a team as a code owner March 18, 2024 13:29
@iamacook iamacook merged commit f1fcd62 into main Mar 18, 2024
16 checks passed
@iamacook iamacook deleted the locking-swagger-address branch March 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants