Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding Swap Orders in Multisends #1348

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Commits on Mar 27, 2024

  1. Add support for decoding Swap Orders in Multisends

    - Swap Orders inside a Multisend should be decoded in the same way as regular ones.
    - Detection of a Multisend order happens on the first level of transactions (i.e. it does not detect Swap transactions if a Multisend contains another Multisend).
    - The `mapSwapOrder` function also changed:
      * It is no longer restricted to a `MultisigTransaction` or `ModuleTransaction` – this was done to support nested transactions which do not have all the properties of a Multisig or Module transactions.
      * It no longer maps to a `CustomTransactionInfo` – this is now a decision left for the callers. Instead, the promise is rejected if the swap transaction couldn't be decoded successfully.
    fmrsabino committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4f59382 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. PR comments

    fmrsabino committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6c234fe View commit details
    Browse the repository at this point in the history