-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RelayLegacyDto
to zod
#1362
Conversation
Pull Request Test Coverage Report for Build 8567936424Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
}, | ||
required: ['chainId', 'to', 'data'], | ||
}; | ||
export const RelayLegacyDtoSchema = z.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: to move the schema closer to the entity. In this case to src/routes/relay/entities/relay.legacy.dto.entity.ts
(I think it helps with code navigation – less jumps).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved in 0893309.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
This migrates the validation of
RelayLegacyDto
tozod
.Changes
RelayLegacyDtoValidationPipe
and associated schemas.RelayLegacyDtoSchema
and infer types from it.