Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ajv and ajv-formats #1397

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Remove ajv and ajv-formats #1397

merged 12 commits into from
Apr 24, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 12, 2024

⚠️ Depends on #1396

Summary

This removes the ajv and ajv-formats packages, as well as all associated usage relevant to the validation implementation prior to migrating to zod.

Changes

  • Uninstall ajv and ajv-formats
  • Remove ValidationModule
  • Remove ValidationErrorFactory
  • Remove JsonSchemaService
  • Remove GenericValidator and IValidator/IPageValidator interfaces

@iamacook iamacook self-assigned this Apr 12, 2024
@iamacook iamacook changed the title Remove ajv Remove ajv and ajv-formats Apr 12, 2024
@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8796974266

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.267%

Totals Coverage Status
Change from base Build 8796886222: 0.03%
Covered Lines: 6806
Relevant Lines: 7120

💛 - Coveralls

@iamacook iamacook marked this pull request as ready for review April 12, 2024 09:24
@iamacook iamacook requested a review from a team as a code owner April 12, 2024 09:24
hectorgomezv
hectorgomezv previously approved these changes Apr 23, 2024
@fmrsabino fmrsabino added the in review Someone is reviewing this Pull Request label Apr 24, 2024
fmrsabino
fmrsabino previously approved these changes Apr 24, 2024
@fmrsabino fmrsabino removed the in review Someone is reviewing this Pull Request label Apr 24, 2024
Base automatically changed from transaction-types-zod to main April 24, 2024 13:20
@iamacook iamacook dismissed stale reviews from fmrsabino and hectorgomezv April 24, 2024 13:20

The base branch was changed.

@iamacook iamacook merged commit 6f0e477 into main Apr 24, 2024
16 checks passed
@iamacook iamacook deleted the remove-ajv branch April 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants