Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onlyListed to CacheRouter.getSafeAppsCacheDir argument list #1462

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add onlyListed to CacheRouter.getSafeAppsCacheDir argument list #1462

merged 1 commit into from
Apr 26, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Adds onlyListed parameter to the CacheDir field when storing Safe Apps list in the cache.

@hectorgomezv hectorgomezv self-assigned this Apr 25, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner April 25, 2024 17:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8836611946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 91.925%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 80.0%
Totals Coverage Status
Change from base Build 8836235273: -0.01%
Covered Lines: 6882
Relevant Lines: 7225
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 809c07d into main Apr 26, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the fix-get-safe-apps-cache-dir branch April 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook