Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @typescript-eslint/no-base-to-string instances #1465

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

iamacook
Copy link
Member

Summary

When updating to ESLint 9, some rules had to be ignored as their recommendations changed. Of which, was the @typescript-eslint/no-base-to-string rule.

This removes instances of where values that can't be stringified are being stringified.

Changes

  • Enable @typescript-eslint/no-base-to-string ESLint rule
  • Stringify addresses, not objects of signers in:
    • routes/email/guards/email-edit.guard.spec.ts
    • routes/email/guards/email-retrieval.guard.spec.ts

@iamacook iamacook self-assigned this Apr 26, 2024
@iamacook iamacook requested a review from a team as a code owner April 26, 2024 11:23
@coveralls
Copy link

coveralls commented Apr 26, 2024

Pull Request Test Coverage Report for Build 8850355250

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 91.834%

Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
Totals Coverage Status
Change from base Build 8850339255: 0.0%
Covered Lines: 6895
Relevant Lines: 7239

💛 - Coveralls

@iamacook iamacook enabled auto-merge (squash) April 26, 2024 15:09
@iamacook iamacook merged commit 8dc1fac into main Apr 26, 2024
13 checks passed
@iamacook iamacook deleted the no-base-to-string branch April 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants