Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locking feature flag #1472

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove locking feature flag #1472

merged 1 commit into from
Apr 26, 2024

Conversation

iamacook
Copy link
Member

Summary

Now that locking is live and in use, there is no need for a feature flag. This removes the features.locking configuration and associated logic.

Changes

  • Remove features.locking from configuration
  • Remove conditional module loading
  • Remove opt-in from test

@iamacook iamacook self-assigned this Apr 26, 2024
@iamacook iamacook requested a review from a team as a code owner April 26, 2024 14:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8850196796

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 91.86%
Totals Coverage Status
Change from base Build 8850065908: -0.005%
Covered Lines: 6896
Relevant Lines: 7239
💛 - Coveralls

@iamacook iamacook enabled auto-merge (squash) April 26, 2024 15:12
@iamacook iamacook merged commit 1414430 into main Apr 26, 2024
16 checks passed
@iamacook iamacook deleted the locking-ff branch April 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamacook @coveralls @hectorgomezv