Map TransactionInfo according to Transfer['type']
#1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Apr 29, 2024
| @@ -84,7 +79,7 @@ export class TransferInfoMapper { | |||
| token?.logoUri, | |||
| token?.trusted, | |||
| ); | |||
| } else if (isNativeTokenTransfer(domainTransfer)) { | |||
| } else if (domainTransfer.type === 'ETHER_TRANSFER') { | |||
There was a problem hiding this comment.
These changes passe our tests and I also tested them against live data.
Pull Request Test Coverage Report for Build 8876525833Details
💛 - Coveralls |
iamacook
commented
Apr 29, 2024
Comment on lines
-44
to
-46
| export function isERC20Transfer(transfer: Transfer): transfer is ERC20Transfer { | ||
| return hasTokenAddress(transfer) && hasValue(transfer); | ||
| } |
There was a problem hiding this comment.
I removed the helpers as they are only used in one file.
fmrsabino
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were mapping the types of
Transfers based on properties in the entity. However, atypedecriminator exists. Migrating to this was marked as a TODO and this adjusts the code to instead use that.Changes
isERC20Transferto instead check fortype === ERC20_TRANSFERisERC721Transferto instead check fortype === ERC721_TRANSFERisNativeTokenTransferto instead check fortype === ETHER_TRANSFER