Improve flakiness of imitation transaction tests #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
May 16, 2024
Comment on lines
+1466
to
+1467
| const getImitationTokenAddressUrl = `${chain.transactionService}/api/v1/tokens/${imitationToken.address}`; | ||
| const getTokenAddressUrl = `${chain.transactionService}/api/v1/tokens/${multisigToken.address}`; |
There was a problem hiding this comment.
I changed this whilst testing and haven't reverted it as it removed the necessity of expecting errors.
Pull Request Test Coverage Report for Build 9112484146Details
💛 - Coveralls |
hectorgomezv
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The imitation transaction tests were intermittently failing as the mocked transfers could have
values of0. This meant that they were not "trusted" and filtered from results.This ensures that the transfers always have a
valueabove0.Changes