Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /locking and /campaign routes under /community #1560

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

iamacook
Copy link
Member

Summary

The Locking Service was previously only locking-related. As such, we located all routes of the Service under /locking. As we are now serving /campaigns, it does not make sense to have them located under /locking.

This moves all Locking Service-related routes under /community, aligning with the domain of the Activity Program.

Note: the aforementioned deprecations redirect requests to their relative new route. They will be removed once the client has migrated

Changes

  • Rename Locking- module, controller, service to Community-.
  • Rename the following (as of yet unused) routes:
    • GET /v1/locking/campaigns ->/v1/community/campaigns
    • GET /v1/locking/campaigns/:campaignId ->/v1/community/campaigns/:campaignId
    • GET /v1/locking/campaigns/:campaignId/leaderboard -> /v1/community/campaigns/:campaignId/leaderboard
  • Rename the following (and deprecate with a redirection of the currently used) routes:
    • GET /v1/locking/leaderboard -> /v1/community/locking/leaderboard
    • GET /v1/locking/leaderboard/rank/:safeAddress -> /v1/community/locking/:safeAddress/rank
    • GET /v1/locking/:safeAddress/history -> /v1/community/locking/:safeAddress/history

@iamacook iamacook self-assigned this May 17, 2024
@iamacook iamacook requested a review from a team as a code owner May 17, 2024 08:58
@iamacook iamacook enabled auto-merge (squash) May 17, 2024 09:00
@iamacook iamacook merged commit cbf7de8 into main May 17, 2024
14 checks passed
@iamacook iamacook deleted the community-routes branch May 17, 2024 09:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9125653993

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 51 of 51 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.866%

Totals Coverage Status
Change from base Build 9116135683: 0.05%
Covered Lines: 7112
Relevant Lines: 7366

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants