Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @typescript-eslint/no-unsafe-enum-comparison instances #1566

Merged
merged 1 commit into from
May 27, 2024

Conversation

iamacook
Copy link
Member

Summary

In the process of updating to ESLint 9, some rules were temporarily ignored due to changes in their recommendations. One of these rules was the @typescript-eslint/no-unsafe-enum-comparison rule.

This PR re-enables the @typescript-eslint/no-unsafe-enum-comparison rule and addresses instances where "unsafe" enum comparison occurs.

Changes

  • Enable @typescript-eslint/no-unsafe-enum-comparison rule in eslint.config.mjs
  • Fix all "unsafe" enum comparison

@iamacook iamacook self-assigned this May 17, 2024
@iamacook iamacook requested a review from a team as a code owner May 17, 2024 15:34
@iamacook iamacook enabled auto-merge (squash) May 17, 2024 15:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9130697714

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 92.908%

Totals Coverage Status
Change from base Build 9126419583: 0.06%
Covered Lines: 7116
Relevant Lines: 7368

💛 - Coveralls

@iamacook iamacook disabled auto-merge May 27, 2024 08:45
@iamacook iamacook merged commit 8ffc04b into main May 27, 2024
16 checks passed
@iamacook iamacook deleted the no-unsafe-enum-comparison branch May 27, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants