Checksum safeAddress
of collectibles fetching and propagate type
#1568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to maintain a strict type and checksummed address throughout the project, we should validate the incoming addresses. In newer controllers, we started doing this by adding an
AddressSchema
to address. This begins adding it to "existing" controllers.This checksums the incoming
safeAddress
ofBalancesController['getCollectibles']
and propagates the stricter (0x${string}
) type throughout the project accordinglyChanges
safeAddress
ofBalancesController['getCollectibles']
safeAddress
argument ofBalancesService['getCollectibles | clearCollectibles']
safeAddress
argument type ofIBalancesRepository['getCollectibles | clearCollectibles']
and all implementorsafeAddress
argument type ofIBalancesApi['getCollectibles']
and all implementors (Safe/Zerion)safeAddress
type of Safe/Zerion balance cache