Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add campaign rank retrieval to locking API #1575

Merged
merged 3 commits into from
May 21, 2024
Merged

Add campaign rank retrieval to locking API #1575

merged 3 commits into from
May 21, 2024

Conversation

iamacook
Copy link
Member

Summary

We want to show the rank of a particular address per campaign. This adds the correct mapping to the locking API according to the Locking Service:

GET /api/v1/campaigns/:campaignId/leaderboard/:safeAddress

Changes

  • Add ILockingApi['getCampaignRank']
  • Add associated tests

@iamacook iamacook self-assigned this May 21, 2024
@iamacook iamacook requested a review from a team as a code owner May 21, 2024 07:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9170848774

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 92.819%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 3 60.0%
Totals Coverage Status
Change from base Build 9170744247: -0.09%
Covered Lines: 7115
Relevant Lines: 7371
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 1109b86 into main May 21, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the locking-api-campaign-rank branch May 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamacook @coveralls @hectorgomezv