Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add campaign rank route #1576

Merged
merged 5 commits into from
May 21, 2024
Merged

Add campaign rank route #1576

merged 5 commits into from
May 21, 2024

Conversation

iamacook
Copy link
Member

Summary

This adds a new route for retrieving the rank of the specified address of the specified campaign:

GET /v1/community/campaigns/:campaignId/leaderboard/:safeAddress

Changes

  • Add ICommunityRespository['getCampaignRank'] and implementation
  • Add CommunityController['getCampaignRank]` under aforementioned route
  • Add associated tests

@iamacook iamacook self-assigned this May 21, 2024
@iamacook iamacook requested a review from a team as a code owner May 21, 2024 08:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9171097665

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 92.833%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 1 90.0%
src/routes/transactions/mappers/common/transaction-info.mapper.ts 1 78.41%
Totals Coverage Status
Change from base Build 9170821741: -0.07%
Covered Lines: 7123
Relevant Lines: 7377
💛 - Coveralls

hectorgomezv
hectorgomezv previously approved these changes May 21, 2024
View reviewed changes
Base automatically changed from locking-api-campaign-rank to main May 21, 2024 09:20
@hectorgomezv hectorgomezv dismissed their stale review May 21, 2024 09:20

The base branch was changed.

@hectorgomezv hectorgomezv self-requested a review May 21, 2024 09:20
@hectorgomezv hectorgomezv merged commit b177608 into main May 21, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the campaign-rank-route branch May 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamacook @coveralls @hectorgomezv